Issue 3520016: Replace the icons for the Page Info Bubble warnings and errors....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3520016: Replace the icons for the Page Info Bubble warnings and errors.... (Closed)

Created:
10 years, 2 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Robert Sesek, alcor

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Replace the icons for the Page Info Bubble warnings and errors. Instead of red padlock warning, we now have gray padlock with yellow triangle over it. Instead of skull and bones error, we now have red padlock with x over it. This matches better with the icons in the Omnibox. BUG=52916 TEST=Visual inspection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61627

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	chrome/app/theme/pageinfo_bad.png	View		Binary file		0 comments	Download
	M	chrome/app/theme/pageinfo_warning_minor.png	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

drive-by LGTM.

Expand Messages | Collapse Messages