Issue 3520011: crash-reporter: detect guest mode and defer crash sending

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3520011: crash-reporter: detect guest mode and defer crash sending (Closed)

Created:
10 years, 2 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/crash-reporter.git

Visibility:
Public.

Description

crash-reporter: detect guest mode and defer crash sending Change-Id: I8952fc6e701521dbb8618889d96ebc025f713427 BUG=7203 TEST=Ran BVTs Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fa101c6

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	crash_sender	View		4 chunks	+15 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-10-01 22:10:52 UTC) #2

LGTM w/ a nit.

http://codereview.chromium.org/3520011/diff/1/2
File crash_sender (right):

http://codereview.chromium.org/3520011/diff/1/2#newcode19
crash_sender:19: CONSENT_ID="/home/chronos/Consent To Send Stats"
Unused now? Remove if so.

Expand Messages | Collapse Messages