Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: WebCore/rendering/RenderBlock.cpp

Issue 3520007: Merge 68485 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/text/dirty-inline-textbox-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1419 matching lines...) Expand 10 before | Expand all | Expand 10 after
1430 runInChild = nextSibling; 1430 runInChild = nextSibling;
1431 } 1431 }
1432 1432
1433 // Now insert the new child under |currBlock|. 1433 // Now insert the new child under |currBlock|.
1434 currBlock->children()->insertChildNode(currBlock, inlineRunIn, currBlock->fi rstChild()); 1434 currBlock->children()->insertChildNode(currBlock, inlineRunIn, currBlock->fi rstChild());
1435 1435
1436 // If the run-in had an element, we need to set the new renderer. 1436 // If the run-in had an element, we need to set the new renderer.
1437 if (runInNode) 1437 if (runInNode)
1438 runInNode->setRenderer(inlineRunIn); 1438 runInNode->setRenderer(inlineRunIn);
1439 1439
1440 // Destroy the block run-in. 1440 // Destroy the block run-in, which includes deleting its line box tree.
1441 blockRunIn->deleteLineBoxTree();
1441 blockRunIn->destroy(); 1442 blockRunIn->destroy();
1442 1443
1443 // The block acts like an inline, so just null out its 1444 // The block acts like an inline, so just null out its
1444 // position. 1445 // position.
1445 1446
1446 return true; 1447 return true;
1447 } 1448 }
1448 1449
1449 int RenderBlock::collapseMargins(RenderBox* child, MarginInfo& marginInfo) 1450 int RenderBlock::collapseMargins(RenderBox* child, MarginInfo& marginInfo)
1450 { 1451 {
(...skipping 4266 matching lines...) Expand 10 before | Expand all | Expand 10 after
5717 else if (isAnonymous()) 5718 else if (isAnonymous())
5718 return "RenderBlock (generated)"; 5719 return "RenderBlock (generated)";
5719 if (isRelPositioned()) 5720 if (isRelPositioned())
5720 return "RenderBlock (relative positioned)"; 5721 return "RenderBlock (relative positioned)";
5721 if (isRunIn()) 5722 if (isRunIn())
5722 return "RenderBlock (run-in)"; 5723 return "RenderBlock (run-in)";
5723 return "RenderBlock"; 5724 return "RenderBlock";
5724 } 5725 }
5725 5726
5726 } // namespace WebCore 5727 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/text/dirty-inline-textbox-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698