Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 3520006: Do not invoke indexed interceptor getters for negative indices. (Closed)
Patch Set: Addressing Vitaly concern Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 867 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 // -- eax : key 878 // -- eax : key
879 // -- edx : receiver 879 // -- edx : receiver
880 // -- esp[0] : return address 880 // -- esp[0] : return address
881 // ----------------------------------- 881 // -----------------------------------
882 Label slow; 882 Label slow;
883 883
884 // Check that the receiver isn't a smi. 884 // Check that the receiver isn't a smi.
885 __ test(edx, Immediate(kSmiTagMask)); 885 __ test(edx, Immediate(kSmiTagMask));
886 __ j(zero, &slow, not_taken); 886 __ j(zero, &slow, not_taken);
887 887
888 // Check that the key is a smi. 888 // Check that the key is an array index, that is Uint32.
889 __ test(eax, Immediate(kSmiTagMask)); 889 __ test(eax, Immediate(kSmiTagMask | kSmiSignMask));
890 __ j(not_zero, &slow, not_taken); 890 __ j(not_zero, &slow, not_taken);
891 891
892 // Get the map of the receiver. 892 // Get the map of the receiver.
893 __ mov(ecx, FieldOperand(edx, HeapObject::kMapOffset)); 893 __ mov(ecx, FieldOperand(edx, HeapObject::kMapOffset));
894 894
895 // Check that it has indexed interceptor and access checks 895 // Check that it has indexed interceptor and access checks
896 // are not enabled for this object. 896 // are not enabled for this object.
897 __ movzx_b(ecx, FieldOperand(ecx, Map::kBitFieldOffset)); 897 __ movzx_b(ecx, FieldOperand(ecx, Map::kBitFieldOffset));
898 __ and_(Operand(ecx), Immediate(kSlowCaseBitFieldMask)); 898 __ and_(Operand(ecx), Immediate(kSlowCaseBitFieldMask));
899 __ cmp(Operand(ecx), Immediate(1 << Map::kHasIndexedInterceptor)); 899 __ cmp(Operand(ecx), Immediate(1 << Map::kHasIndexedInterceptor));
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
1980 ExternalReference ref = ExternalReference(IC_Utility(kKeyedStoreIC_Miss)); 1980 ExternalReference ref = ExternalReference(IC_Utility(kKeyedStoreIC_Miss));
1981 __ TailCallExternalReference(ref, 3, 1); 1981 __ TailCallExternalReference(ref, 3, 1);
1982 } 1982 }
1983 1983
1984 #undef __ 1984 #undef __
1985 1985
1986 1986
1987 } } // namespace v8::internal 1987 } } // namespace v8::internal
1988 1988
1989 #endif // V8_TARGET_ARCH_IA32 1989 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698