Issue 3519016: Enable the new page info bubble by default.

Issue 3519016: Enable the new page info bubble by default. (Closed)

Created:
10 years, 2 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enable the new page info bubble by default. BUG=52916 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61932

Patch Set 3 : '' #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -24 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.mm	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/labs.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/page_info_model.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		2 chunks	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Finnur

Since the platforms have parity and I don't know of anything remaining (except bug 58162, ...

10 years, 2 months ago (2010-10-07 15:58:54 UTC) #1

Robert Sesek

http://codereview.chromium.org/3519016/diff/1/5 File chrome/browser/views/frame/browser_view.cc (right): http://codereview.chromium.org/3519016/diff/1/5#newcode1215 chrome/browser/views/frame/browser_view.cc:1215: if (!command_line->HasSwitch(switches::kDisableNewPageInfoBubble)) I think you'll need to make this ...

10 years, 2 months ago (2010-10-07 16:02:54 UTC) #2

Finnur

Good catch! Thanks. Uploaded. On 2010/10/07 16:02:54, rsesek wrote: > http://codereview.chromium.org/3519016/diff/1/5 > File chrome/browser/views/frame/browser_view.cc (right): ...

10 years, 2 months ago (2010-10-07 16:11:14 UTC) #3

Robert Sesek

10 years, 2 months ago (2010-10-07 16:15:22 UTC) #4

LGTM

http://codereview.chromium.org/3519016/diff/17001/18007
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/3519016/diff/17001/18007#newcode239
chrome/common/chrome_switches.cc:239: const char kDisableNewPageInfoBubble[]    
  = "disable-new-page-info-bubble";
nit: align '=' with other lines

Expand Messages | Collapse Messages