Issue 3518005: Make some free functions into static members of class Parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3518005: Make some free functions into static members of class Parser. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Make some free functions into static members of class Parser. Committed: http://code.google.com/p/v8/source/detail?r=5576

Patch Set 1 #

Patch Set 2 : Remove commented-out code. #

Patch Set 3 : Remove outdated comment. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+317 lines, -313 lines)			Patch
M	src/api.cc	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	src/compiler.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler.cc	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	src/jsregexp.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/liveedit.cc	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	src/parser.h	View		3 chunks	+278 lines, -28 lines	0 comments	Download
M	src/parser.cc	View	1 2	7 chunks	+15 lines, -269 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

10 years, 2 months ago (2010-09-30 12:30:08 UTC) #1

There was a comment that the toplevel functions were to avoid putting the
definition of class Parser in parser.h.

It seems to me that the V8 codebase is big enough that free functions are to be
avoided and a class in a header file is not a big deal.

I've swizzled the includes so parser.h is no longer included by compiler.h and
now is only included in .cc files where it's needed.

Expand Messages | Collapse Messages