Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 3518002: Roll DEPS to include changes to FFmpeg build system (Closed)

Created:
10 years, 2 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
fbarchard
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Roll DEPS to include changes to FFmpeg build system This change will avoid exporting libvpx symbols if libvpx is not built into FFmpeg. BUG=None TEST=FFmpeg can be loaded on ARM Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61013

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/generate_stubs/generate_stubs.py View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
10 years, 2 months ago (2010-09-29 02:17:12 UTC) #1
Alpha Left Google
I need to change DEPS to a different version after changes to ffmpeg.gyp is committed.
10 years, 2 months ago (2010-09-29 02:18:27 UTC) #2
fbarchard
http://codereview.chromium.org/3518002/diff/1/3 File tools/generate_stubs/generate_stubs.py (right): http://codereview.chromium.org/3518002/diff/1/3#newcode3 tools/generate_stubs/generate_stubs.py:3: # Copyright (c) 2009 The Chromium Authors. All rights ...
10 years, 2 months ago (2010-09-29 05:03:06 UTC) #3
Alpha Left Google
On 2010/09/29 05:03:06, fbarchard wrote: > http://codereview.chromium.org/3518002/diff/1/3 > File tools/generate_stubs/generate_stubs.py (right): > > http://codereview.chromium.org/3518002/diff/1/3#newcode3 > ...
10 years, 2 months ago (2010-09-29 05:42:30 UTC) #4
fbarchard
10 years, 2 months ago (2010-09-29 17:29:15 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698