HttpAuthHandlerFactory::CreateDefault requires a HostResolver argument.

HttpAuthHandlerFactory::CreateDefault requires a HostResolver argument.

Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL. 

So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.

BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60942

[cbentzel, 2010-09-28 19:32:58]

Eric, this is the same CL as before but adds chrome/test/plugin/plugin_test.cpp

Unfortunately, that target was not in trybots, and I didn't find with rgrep due
to the .cpp ending (instead of .cc)

I'll rename in a separate patch.

[eroman, 2010-09-28 22:19:37]

lgtm