Issue 3517013: Add ActivateManual, ActivateManualDebug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3517013: Add ActivateManual, ActivateManualDebug (Closed)

Created:
10 years, 2 months ago by rochberg

Modified:
9 years, 7 months ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/modemmanager.git

Visibility:
Public.

Description

Add ActivateManual, ActivateManualDebug BUG=6885 TEST=built modemmanager and cromo Change-Id: Ib73a093b13da05948a2f1da8f051fe7c55682584 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f447c8e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -13 lines)			Patch
M	introspection/mm-modem-cdma.xml	View	1	2 chunks	+43 lines, -13 lines	0 comments	Download
M	src/mm-modem-cdma.h	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/mm-modem-cdma.c	View		2 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

10 years, 2 months ago (2010-10-06 04:58:44 UTC) #2

See comments below on the xml.  The actually code LGTM.

http://codereview.chromium.org/3517013/diff/1/2
File introspection/mm-modem-cdma.xml (right):

http://codereview.chromium.org/3517013/diff/1/2#newcode22
introspection/mm-modem-cdma.xml:22: not contact the carrier.  It does, however,
reset the modem.
What does this mean "reset the modem"?

http://codereview.chromium.org/3517013/diff/1/2#newcode33
introspection/mm-modem-cdma.xml:33: <method name="ActivateManualDebug">
Seems funny to add this due to a dbus-send bug.  Shouldn't we fix dbus-send?

Expand Messages | Collapse Messages