Issue 3517012: Speculative fix for SpdySettingsStorage crasher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3517012: Speculative fix for SpdySettingsStorage crasher. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Speculative fix for SpdySettingsStorage crasher. I've added a unit test to exercise the code, but it didn't trigger the crash. BUG=57331 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61880

Patch Set 1 #

Patch Set 2 : Oops. #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -3 lines)			Patch
M	net/spdy/spdy_session.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	net/spdy/spdy_session.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View	1	3 chunks	+123 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

Is there something missing? I don't see the change to actually use the new method ...

10 years, 2 months ago (2010-10-06 11:44:47 UTC) #2

willchan no longer on Chromium

Oops. Fixed. On 2010/10/06 11:44:47, Mike Belshe wrote: > Is there something missing? I don't ...

10 years, 2 months ago (2010-10-06 17:53:16 UTC) #3

Mike Belshe

10 years, 2 months ago (2010-10-07 20:50:57 UTC) #4

lgtm

http://codereview.chromium.org/3517012/diff/4001/5003
File net/spdy/spdy_session_unittest.cc (right):

http://codereview.chromium.org/3517012/diff/4001/5003#newcode130
net/spdy/spdy_session_unittest.cc:130: session_->CloseSessionOnError(ERR_FAILED,
false);
The Settings message will have been processed before we get to here, so I'm not
surprised that this test case doesn't trigger the fail.

Expand Messages | Collapse Messages