Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 3517010: Close tree when smoke bvt fails. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
rtc
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Close tree when smoke bvt fails. Change-Id: I01d613527777098616e8d5bd2b4b27bce240c02f BUG= TEST=Ran cbuildbot and prematurely killed autotest to show test failure. CBuildbot fails saying that cros_run_vm_test smoke_Suite failed. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d9bbe87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bin/cbuildbot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
10 years, 2 months ago (2010-10-05 20:21:38 UTC) #1
rtc
10 years, 2 months ago (2010-10-05 20:23:05 UTC) #2
LGTM

You should send a note to the team (cc the sheriffs directly) and give them
a heads up that the change is coming. Also, it would be nice if you could
tell people how to run the VM tests before committing.

-Ryan

On Tue, Oct 5, 2010 at 1:21 PM, <sosa@chromium.org> wrote:

> Reviewers: rtc,
>
> Description:
> Close tree when smoke bvt fails.
>
> Change-Id: I01d613527777098616e8d5bd2b4b27bce240c02f
>
> BUG=
> TEST=Ran cbuildbot and prematurely killed autotest to show test failure.
> CBuildbot fails saying that cros_run_vm_test smoke_Suite failed.
>
> Please review this at http://codereview.chromium.org/3517010/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M bin/cbuildbot.py
>
>
> Index: bin/cbuildbot.py
> diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
> index
>
e01fe18627c51e1e55b98980ceb9cf1ff1218442..37a8b6e2691943905479a02594c9e510f9bed561
> 100755
> --- a/bin/cbuildbot.py
> +++ b/bin/cbuildbot.py
> @@ -300,7 +300,7 @@ def _RunSmokeSuite(buildroot):
>               '--no_graphics',
>               '--test_case',
>               'suite_Smoke',
> -              ], cwd=cwd, error_ok=True)
> +              ], cwd=cwd, error_ok=False)
>
>
>  def _UprevPackages(buildroot, revisionfile, board):
>
>
>

Powered by Google App Engine
This is Rietveld 408576698