Issue 3517004: Revert 60997 - o Add user customizable launch type for apps by adding options...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3517004: Revert 60997 - o Add user customizable launch type for apps by adding options... (Closed)

Created:
10 years, 2 months ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Bons

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, arv (Not doing code reviews), pam+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 60997 - o Add user customizable launch type for apps by adding options in each apps context menu. o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification. o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist. o Some minor refactoring within the code to reduce duplication. BUG=54731 TEST=NONE patch from issue 3419010 Review URL: http://codereview.chromium.org/3453029 TBR=andybons@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61000

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -307 lines)			Patch
M	chrome/browser/browser.cc	View	2 chunks	+7 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/app_launcher_handler.h	View	3 chunks	+1 line, -16 lines	0 comments	Download
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	10 chunks	+12 lines, -46 lines	0 comments	Download
M	chrome/browser/dom_ui/ntp_resource_cache.cc	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	3 chunks	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	20 chunks	+22 lines, -74 lines	0 comments	Download
M	chrome/browser/prefs/pref_notifier.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_service.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	6 chunks	+1 line, -50 lines	0 comments	Download
M	chrome/browser/resources/shared/css/menu.css	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/browser/resources/shared/images/checkbox_black.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/shared/images/checkbox_white.png	View	Binary file		0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/command.js	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/menu_item.js	View	4 chunks	+0 lines, -11 lines	0 comments	Download
M	tools/grit/grit/format/html_inline.py	View	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages