Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 3516004: Exported utility functions for RTC and system sleep (Closed)

Created:
10 years, 2 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sameer Nanda
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Exported utility functions for RTC and system sleep Converted the suspend and RTC functions from module methods in bin/base_utils.py to separate modules in common_lib/ which have no cross dependencies. The downside to this apprach is that we don't use utils.run() to call powerd_supspend, which loses us a little logging. This will allow otherse to use these modules in non-autotest-embedded test scripts. BUG=none TEST=rerun power_Resume test using run_remote_tests, manually grep for all moved function names in the rest of the autotest source tree. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7a0e9d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -61 lines) Patch
M client/bin/base_utils.py View 1 chunk +0 lines, -57 lines 0 comments Download
A client/common_lib/rtc.py View 1 chunk +14 lines, -0 lines 0 comments Download
A client/common_lib/sys_power.py View 1 chunk +32 lines, -0 lines 0 comments Download
M client/site_tests/power_Resume/power_Resume.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 2 months ago (2010-09-28 22:45:30 UTC) #1
Sameer Nanda
10 years, 2 months ago (2010-09-28 22:49:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698