Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 351027: [Mac] Prefs window sizing/spacing:... (Closed)

Created:
11 years, 1 month ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Prefs window sizing/spacing: - Make some vertical spacing in basics more consistent - Make some vertical spacing in personal stuff more consistent - Make the views a bit wider to avoid some clipping and wrapping in a few languages. - A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc). TEST=window looks ok (given our strings it won't always look great, but shoot for ok). BUG=26586 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30871

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -90 lines) Patch
M chrome/app/nibs/Preferences.xib View 1 2 3 47 chunks +66 lines, -66 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 2 3 3 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
TVL
11 years, 1 month ago (2009-11-03 21:02:51 UTC) #1
Avi (use Gerrit)
drive-by grammar cop http://codereview.chromium.org/351027/diff/1/3 File chrome/browser/cocoa/preferences_window_controller.mm (right): http://codereview.chromium.org/351027/diff/1/3#newcode425 Line 425: // width. They should be ...
11 years, 1 month ago (2009-11-03 21:15:21 UTC) #2
Mark Mentovai
11 years, 1 month ago (2009-11-03 21:47:17 UTC) #3
LG

"size" is also confused with "width" in the description, fix?

http://codereview.chromium.org/351027/diff/1003/7
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/351027/diff/1003/7#newcode425
Line 425: // width.  They should be the same sizes, so they are laid out to look
as good
If you said width, you should say size.

If you said sizes, you should have said widths.

Do you really mean sizes, though?

Powered by Google App Engine
This is Rietveld 408576698