Issue 351026: Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351026: Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand.... (Closed)

Created:
11 years, 1 month ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand. This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil. Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager, ModelSafeWorker, etc from progress state. BUG=25266 TEST=sync unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30868

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -46 lines)			Patch
M	chrome/browser/sync/engine/apply_updates_command.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/apply_updates_command.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/conflict_resolver.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer_util.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_util.cc	View		3 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/engine/update_applicator.h	View		2 chunks	+15 lines, -13 lines	0 comments	Download
M	chrome/browser/sync/engine/update_applicator.cc	View	1	3 chunks	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

11 years, 1 month ago (2009-11-03 21:33:06 UTC) #2

OK

http://codereview.chromium.org/351026/diff/1/2
File chrome/browser/sync/engine/update_applicator.cc (right):

http://codereview.chromium.org/351026/diff/1/2#newcode21
Line 21: : resolver_(resolver), begin_(begin), end_(end), pointer_(begin),
One per line, please.

Expand Messages | Collapse Messages