app/gfx/font.h - Issue 351024: Fixed font height on OS X. Also added some unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/gfx/font.h

Issue 351024: Fixed font height on OS X. Also added some unittests. (Closed)

Patch Set: Expanded on comment. Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: app/gfx/font.h

diff --git a/app/gfx/font.h b/app/gfx/font.h

index ccc1a64ecdbcdf5102e165acd4e882bc11e798a7..80a85ecd4b1df539a06fb2dac3b02d6c3386b52e 100644

--- a/app/gfx/font.h

+++ b/app/gfx/font.h

@@ -73,7 +73,10 @@ class Font {

Font DeriveFont(int size_delta, int style) const;

// Returns the number of vertical pixels needed to display characters from

- // the specified font.

+ // the specified font. This may include some leading, i.e. height may be

+ // greater than just ascent + descent. Specifically, the Windows and Mac

+ // implementations include leading and the Linux one does not. This may

+ // need to be revisited in the future.

int height() const;

// Returns the baseline, or ascent, of the font.

« no previous file with comments | « no previous file | app/gfx/font_mac.mm » ('j') | no next file with comments »