Issue 351023: BrowserActionsContainer breaks for nobody... or maybe someone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351023: BrowserActionsContainer breaks for nobody... or maybe someone (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

BrowserActionsContainer breaks for nobody... or maybe someone just forgot to hit the breaks. :) This avoids triggering a NOTREACHED in the default case that I hit during testing. BUG=None TEST=Load the set_page_color sample extension in debug build of Chrome and it should not NOTREACH (it should... um... REACH?) when pressing the browser action icon. :) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30862

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/views/browser_actions_container.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm, whoops http://codereview.chromium.org/351023/diff/1/2 File chrome/browser/views/browser_actions_container.cc (right): http://codereview.chromium.org/351023/diff/1/2#newcode426 Line 426: NOTREACHED() << L"Unexpected notification"; while you're ...

11 years, 1 month ago (2009-11-03 20:11:53 UTC) #2

Finnur

11 years, 1 month ago (2009-11-03 21:00:11 UTC) #3

What!? I like that L!

OK, fine. I'll remove it. :)

On 2009/11/03 20:11:53, Evan Stade wrote:
> lgtm, whoops
> 
> http://codereview.chromium.org/351023/diff/1/2
> File chrome/browser/views/browser_actions_container.cc (right):
> 
> http://codereview.chromium.org/351023/diff/1/2#newcode426
> Line 426: NOTREACHED() << L"Unexpected notification";
> while you're here, could you remove this unsightly L?

Expand Messages | Collapse Messages