Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 351019: Enable mksnapshot on ARM when cross-compiling using gyp (Closed)

Created:
11 years, 1 month ago by piman
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Enable mksnapshot on ARM when cross-compiling using gyp Committed: http://code.google.com/p/v8/source/detail?r=3235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M tools/gyp/v8.gyp View 8 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
11 years, 1 month ago (2009-11-03 05:01:09 UTC) #1
piman
+ager Ping ? If you guys are not the right people to review this, could ...
11 years, 1 month ago (2009-11-05 01:24:11 UTC) #2
Søren Thygesen Gjesse
Sorry for the delay. We should be the right people to look at this. However ...
11 years, 1 month ago (2009-11-05 10:04:15 UTC) #3
Søren Thygesen Gjesse
11 years, 1 month ago (2009-11-05 11:14:21 UTC) #4
LGTM

Thank you for the explanation on the gyp cross-compile details.

Powered by Google App Engine
This is Rietveld 408576698