Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 351017: Add script to scrape valgrind layout bot (Closed)

Created:
11 years, 1 month ago by dank
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Update valgrind_webkit_tests.sh to use the same version of valgrind as valgrind.sh. Add script to locally reproduce the nonleak valgrind errors found recently by the linux valgrind layout bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30904

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -2 lines) Patch
A tools/valgrind/regrind.sh View 2 3 1 chunk +132 lines, -0 lines 0 comments Download
M tools/valgrind/valgrind_webkit_tests.sh View 1 2 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dank
Found at least one UMR (http://crbug.com/26547)
11 years, 1 month ago (2009-11-03 01:08:22 UTC) #1
stuartmorgan
LGTM http://codereview.chromium.org/351017/diff/1/3 File tools/valgrind/relayout.sh (right): http://codereview.chromium.org/351017/diff/1/3#newcode2 Line 2: # Script to reproduce some the non-leak ...
11 years, 1 month ago (2009-11-03 01:23:52 UTC) #2
dank
OK, please re-review. It's a bit fancier now, but does the same thing.
11 years, 1 month ago (2009-11-03 22:22:25 UTC) #3
stuartmorgan
LGTM
11 years, 1 month ago (2009-11-03 22:29:06 UTC) #4
stuartmorgan
11 years, 1 month ago (2009-11-04 00:49:36 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698