Issue 351010: Shifted patterns in tabs and background pattern over so that patterns line up...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351010: Shifted patterns in tabs and background pattern over so that patterns line up... (Closed)

Created:
11 years, 1 month ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Shifted patterns in tabs and background pattern over so that patterns line up correctly with the browser window. BUG=18548 TEST=Open window with Legal Pad theme from the them gallery and make sure the red lines line up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30998

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	chrome/browser/cocoa/browser_frame_view.mm	View	1 2	2 chunks	+11 lines, -10 lines	0 comments	Download
	M	chrome/browser/cocoa/browser_window_controller.mm	View	1 2 3	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmac

Just had to shift some patterns over by 5 pixels. Didn't unify it to a ...

11 years, 1 month ago (2009-11-02 17:02:41 UTC) #1

Nico

11 years, 1 month ago (2009-11-02 18:13:46 UTC) #3

Any chance you could do the windows / linux side as well while you are touching
this? :-) (http://crbug.com/17575 )

Expand Messages | Collapse Messages