Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 351006: Don't run WorkerTest.LimitTotal under Valgrind (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't run WorkerTest.LimitTotal under Valgrind The test hangs and/or crashes with both Valgrind tools we use. BUG=25917, 22608 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30697

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/test/data/valgrind/ui_tests.gtest.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/valgrind/ui_tests.gtest-tsan.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/valgrind/ui_tests.gtest_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
11 years, 1 month ago (2009-11-02 12:59:16 UTC) #1
dank
11 years, 1 month ago (2009-11-02 13:55:42 UTC) #2
rietveld seems broken, I can't view the diffs :-(

So go ahead and commit, I'll review later.

Powered by Google App Engine
This is Rietveld 408576698