Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 3509008: Merge 68345 - document.nodesFromRect() needs to be removed from Document.idl... (Closed)

Created:
10 years, 2 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 68345 - document.nodesFromRect() needs to be removed from Document.idl https://bugs.webkit.org/show_bug.cgi?id=46492 Reviewed by Kenneth Christiansen and Andreas Kling. Patch by Antonio Gomes <agomes@rim.com>; WebCore: As discussed with Sam Weinig on IRC, it was decided to removed nodesFromRect() from the Document.idl, and that way, not exposing it to Web content. Reason: there is no plan to make it standard at the moment, and at the very least, the method should had been originally added with the "webkit" prefix, which was not the case. * dom/Document.idl: LayoutTests: Skip the tests relying on document.nodesFromRect in all platform for the moment, and adjusting the expected results tests also accordingly. * fast/dom/Window/window-properties-expected.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/win/Skipped: TBR=jamesr@chromium.org BUG=57110 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +17 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/gtk/Skipped View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/Skipped View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +3 lines, -0 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +17 lines, -0 lines 0 comments Download
M WebCore/dom/Document.idl View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
10 years, 2 months ago (2010-09-28 05:16:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698