Issue 3509002: Revert some Dr. Memory suppressions since they re-appeared as issue 55 (was: ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3509002: Revert some Dr. Memory suppressions since they re-appeared as issue 55 (was: ... (Closed)

Created:
10 years, 2 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert some Dr. Memory suppressions since they re-appeared as issue 55 (was: issue 49) TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60650

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 2 months ago (2010-09-27 15:50:57 UTC) #2

LGTM

On Mon, Sep 27, 2010 at 7:31 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Revert some Dr. Memory suppressions since they re-appeared as issue 55 (was:
> issue 49)
> TBR=glider
>
> Please review this at http://codereview.chromium.org/3509002/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/drmemory/suppressions.txt
>
>
> Index: tools/valgrind/drmemory/suppressions.txt
> ===================================================================
> --- tools/valgrind/drmemory/suppressions.txt    (revision 60644)
> +++ tools/valgrind/drmemory/suppressions.txt    (working copy)
> @@ -158,6 +158,20 @@
>  UNADDRESSABLE ACCESS
>  ntdll.dll!Rtl*CriticalSection*
>
> +UNADDRESSABLE ACCESS
> +*!Send
> +
> +UNADDRESSABLE ACCESS
> +...
> +*!tracked_objects::Tracked::Tracked
> +
> +UNADDRESSABLE ACCESS
> +*!Pickle::Pickle
> +
> +UNADDRESSABLE ACCESS
> +...
> +*!IPC::ChannelProxy::Context::On*Message*
> +
>  ############################
>  # TODO(timurrrr): investigate these
>  UNINITIALIZED READ
>
>
>

Expand Messages | Collapse Messages