Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 3501001: Build with -fPIC on all arches but x86 32-bit. (Closed)

Created:
10 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, jam, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

linux: Build with -fPIC on all arches but x86 32-bit. I will watch the bots to see if this affects performance. BUG=26625 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61208

Patch Set 1 #

Patch Set 2 : try2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M build/common.gypi View 1 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
Lemme know if this works, from the trybot it seemed maybe not :(
10 years, 3 months ago (2010-09-23 21:55:13 UTC) #1
jam
brad? I don't know enough about this stuff.
10 years, 3 months ago (2010-09-23 21:56:41 UTC) #2
bradn
LGTM, assuming we're not worried about a performance hit?
10 years, 3 months ago (2010-09-23 22:28:31 UTC) #3
jam
btw I verified that this fixes the pdf plugin, i.e. no need to use base_fpic ...
10 years, 3 months ago (2010-09-23 23:50:03 UTC) #4
jam
10 years, 2 months ago (2010-09-28 07:38:51 UTC) #5
ping?

Powered by Google App Engine
This is Rietveld 408576698