Issue 350012: Purge memory for DBs in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350012: Purge memory for DBs in the renderer process. (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Purge memory for DBs in the renderer process. BUG=23400 TEST=none

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	chrome/renderer/render_thread.cc	View		5 chunks	+15 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM http://codereview.chromium.org/350012/diff/1/2 File chrome/renderer/render_thread.cc (right): http://codereview.chromium.org/350012/diff/1/2#newcode587 Line 587: while (sqlite3_release_memory(std::numeric_limits<int>::max()) > 0) do we compile ...

11 years, 1 month ago (2009-10-31 22:39:40 UTC) #2

Peter Kasting

11 years, 1 month ago (2009-11-01 04:16:36 UTC) #3

On 2009/10/31 22:39:40, darin wrote:
> do we compile with -DSQLITE_ENABLE_MEMORY_MANAGEMENT=1

Yes.

Expand Messages | Collapse Messages