chrome/browser/dom_ui/downloads_dom_handler.cc - Issue 350007: Convert chrome_url_data_manager (previously a global) into a Singleton. This

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/downloads_dom_handler.cc

Issue 350007: Convert chrome_url_data_manager (previously a global) into a Singleton. This (Closed)

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/downloads_dom_handler.cc

diff --git a/chrome/browser/dom_ui/downloads_dom_handler.cc b/chrome/browser/dom_ui/downloads_dom_handler.cc

index 7b7791513727ff93d3c70a753fe8af7d788746cd..67994753c71d3567eb1a0f409f31980e9c6cca45 100644

--- a/chrome/browser/dom_ui/downloads_dom_handler.cc

+++ b/chrome/browser/dom_ui/downloads_dom_handler.cc

@@ -7,6 +7,7 @@

#include "app/l10n_util.h"

#include "base/basictypes.h"

#include "base/i18n/time_formatting.h"

+#include "base/singleton.h"

#include "base/string_piece.h"

#include "base/thread.h"

#include "base/values.h"

@@ -54,7 +55,7 @@ DownloadsDOMHandler::DownloadsDOMHandler(DownloadManager* dlm)

// Create our fileicon data source.

ChromeThread::PostTask(

ChromeThread::IO, FROM_HERE,

- NewRunnableMethod(&chrome_url_data_manager,

+ NewRunnableMethod(Singleton<ChromeURLDataManager>().get(),

&ChromeURLDataManager::AddDataSource,

new FileIconSource()));

}