Issue 3499004: AU: Verify that the actual download size matches the size reported by Omaha.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3499004: AU: Verify that the actual download size matches the size reported by Omaha. (Closed)

Created:
10 years, 3 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Verify that the actual download size matches the size reported by Omaha. This patch makes sure that the size of the payload received from the server matches the size reported by Omaha. We could also verify that the HTTP header size field matches the Omaha size but that seems redundant -- ultimately, it's important that the number of bytes that AU actually downloads (and calculates the hash on) matches the Omaha size. BUG=6579 TEST=unit tests, gmerged on device and tested with a regular as well as a modified dev server to send incorrect size. Change-Id: I2f38e2df53e713c0b4f417533028fcb623e2df16 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=50332f1

Patch Set 1 #

Patch Set 2 : extra ; #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -10 lines)			Patch
M	action_processor.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	download_action.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	download_action_unittest.cc	View	1	6 chunks	+35 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages