Display the name of the repository that is being updated.

Display the name of the repository that is being updated.

Patch contributed by Anton Staaf.

BUG=None
TEST=run "gclient config ...; gclient sync chromium"

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61733

[robotboy, 2010-09-28 16:51:17]

depot_tools:

This is a replacement for Issue 3353020.  It keeps track of the maximum number
of characters written and pads the output with spaces to cover them up before
using \r to return the the first column.  I also removed the color highlighting
of the name.  There is a cross platform python package called colorama that we
could use for that, but that would be a separate issue.

[M-A Ruel, 2010-09-28 17:09:04]

http://codereview.chromium.org/3497013/diff/1/2
File gclient_utils.py (right):

http://codereview.chromium.org/3497013/diff/1/2#newcode684
gclient_utils.py:684: self.progress.update(1, task_item.name)
One thing I'd like is to show the currently running jobs instead in that case
since multiple jobs are running at the same time. The trick would be to replace
task_item.name with
', '.join(t.item.name for t in self.running)

wdyt?

http://codereview.chromium.org/3497013/diff/1/3
File third_party/repo/progress.py (right):

http://codereview.chromium.org/3497013/diff/1/3#newcode55
third_party/repo/progress.py:55: self._width = max(len(text), self._width)
Will it screw up once it starts to become longer than the terminal width?
Probably not worth bothering.

[robotboy, 2010-10-05 00:03:54]

http://codereview.chromium.org/3497013/diff/1/2
File gclient_utils.py (right):

http://codereview.chromium.org/3497013/diff/1/2#newcode684
gclient_utils.py:684: self.progress.update(1, task_item.name)
Will do.

http://codereview.chromium.org/3497013/diff/1/3
File third_party/repo/progress.py (right):

http://codereview.chromium.org/3497013/diff/1/3#newcode55
third_party/repo/progress.py:55: self._width = max(len(text), self._width)
Yup, it will fail in that case, I will change the update of _width to just use
the previous width.  That way it will only fail in the same way that it already
fails.  That is it will skip to the next line (twice instead of once, but not
every subsequent time).

[robotboy, 2010-10-05 00:06:39]

I've addressed the two comments, PTAL.

[M-A Ruel, 2010-10-05 00:15:25]

lgtm

http://codereview.chromium.org/3497013/diff/7001/8002
File third_party/repo/progress.py (right):

http://codereview.chromium.org/3497013/diff/7001/8002#newcode50
third_party/repo/progress.py:50: if text is not None:
nit: this would be sufficient:
if text:

[robotboy, 2010-10-05 20:13:20]

Thanks Marc-Antoine.  The pre-submit hooks are still failing for me on gLucid. 
Should I dcommit anyway?  Or should I wait for you to look into that?

[M-A Ruel, 2010-10-05 20:21:32]

On 2010/10/05 20:13:20, robotboy wrote:
> Thanks Marc-Antoine.  The pre-submit hooks are still failing for me on gLucid.

> Should I dcommit anyway?  Or should I wait for you to look into that?

You can dcommit, I'll fix the issues.

[M-A Ruel, 2010-10-06 23:36:06]

On 2010/10/05 20:21:32, Marc-Antoine Ruel wrote:
> On 2010/10/05 20:13:20, robotboy wrote:
> > Thanks Marc-Antoine.  The pre-submit hooks are still failing for me on
gLucid.
> 
> > Should I dcommit anyway?  Or should I wait for you to look into that?
> 
> You can dcommit, I'll fix the issues.

Committed. (Anton had issues committing)