Issue 3496007: Fix error in x64 inlined optimized shift operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3496007: Fix error in x64 inlined optimized shift operators. (Closed)

Created:
10 years, 3 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix error in x64 inlined optimized shift operators. Committed: http://code.google.com/p/v8/source/detail?r=5529

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	src/x64/codegen-x64.cc	View	1 2 3	3 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

10 years, 3 months ago (2010-09-24 15:59:46 UTC) #3

LGTM

http://codereview.chromium.org/3496007/diff/7001/8001
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/3496007/diff/7001/8001#newcode1397
src/x64/codegen-x64.cc:1397: answer.reg(),
Indentation is off.

Expand Messages | Collapse Messages