Issue 3493016: Add EC hash in hardware_Components database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3493016: Add EC hash in hardware_Components database (Closed)

Created:
10 years, 2 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git

Visibility:
Public.

Description

Add EC hash in hardware_Components database In order to check EC in factory process, we must add a hash field from entire EC. NOTE: since some EC may contain special timestamp/calibration fields, those parts must be padded with constant before calculating hash. BUG=chromium-os:1843 TEST=manually: 1. run hardware_Components factory test by: ../../bin/autotest control 2. check ../../results/default/hardware_Components/results/system_components Expected: a long hash number in field 'hash_ec_firmware'. Change-Id: I5bbe41c8d6081253bf78d047e2a450b13d6d802f Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7a35c20

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -20 lines)			Patch
M	client/common_lib/flashrom_util.py	View		2 chunks	+23 lines, -13 lines	0 comments	Download
M	client/site_tests/hardware_Components/approved_components	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	client/site_tests/hardware_Components/hardware_Components.py	View	1 2	5 chunks	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 3493016: Add EC hash in hardware_Components database (Closed)

Description

Patch Set 1 #

Patch Set 2 : (help to refine) removed extra spaces introduced by commit b139313f56a68b880345f73a9e94edad7e065e0c #

Patch Set 3 : change field ordering by alphabet #

Messages