make_image: Fake vmlinuz_hd.vblock on ARM.

make_image: Fake vmlinuz_hd.vblock on ARM.

- This unbreaks the devserver's update server for ARM.
- This also unforks some of build_image.

BUG=None
TEST=Installed to tegra2_seaboard from USB without --skip_vblock,
     updated tegra2_seaboard.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9bc78b3

[Will Drewry, 2010-09-22 00:37:55]

LGTM pending a nit

Adding wfrichar & gauravsh just in case they know of any other uses of hd vblock
you'll get bitten by.

Thanks!

http://codereview.chromium.org/3493004/diff/1/3
File build_kernel_image.sh (right):

http://codereview.chromium.org/3493004/diff/1/3#newcode230
build_kernel_image.sh:230: # TODO: HACK: Create a phony hd.vblock to keep all of
the other scripts running
nit: > 80 chars

[gauravsh, 2010-09-22 06:07:53]

On Tue, Sep 21, 2010 at 5:37 PM,  <wad@chromium.org> wrote:
> LGTM pending a nit
>
> Adding wfrichar & gauravsh just in case they know of any other uses of hd
> vblock
> you'll get bitten by.

Most likely not. The signing scripts don't care if this vblock is
valid. chromeos-install will overwrite the vblock on the kernel
partition but since ARM doesn't have verified boot, this doesn't
matter.

So, LGTM.

>
> Thanks!
>
>
> http://codereview.chromium.org/3493004/diff/1/3
> File build_kernel_image.sh (right):
>
> http://codereview.chromium.org/3493004/diff/1/3#newcode230
> build_kernel_image.sh:230: # TODO: HACK: Create a phony hd.vblock to
> keep all of the other scripts running
> nit: > 80 chars
>
> http://codereview.chromium.org/3493004/show
>



-- 
-g

[Randall Spangler, 2010-09-22 16:06:25]

LGTM with a revised comment

http://codereview.chromium.org/3493004/diff/5001/6002
File build_kernel_image.sh (right):

http://codereview.chromium.org/3493004/diff/5001/6002#newcode231
build_kernel_image.sh:231: # running.
A little more explanation of which scripts would be nice, so we'll have a clue
when the hack can be removed.

Alternately (and preferably), could describe this as "Create the default HD
vblock as a copy of the kernel vblock.  For platforms using verified boot, a
later signing step overwrites this with the vblock signed with the correct key
for booting from HD."

[Kenneth Waters, 2010-09-22 17:48:06]

Randal, ptal.

http://codereview.chromium.org/3493004/diff/5001/6002
File build_kernel_image.sh (right):

http://codereview.chromium.org/3493004/diff/5001/6002#newcode231
build_kernel_image.sh:231: # running.
On 2010/09/22 16:06:25, Randall Spangler wrote:
> A little more explanation of which scripts would be nice, so we'll have a clue
> when the hack can be removed.
> 
> Alternately (and preferably), could describe this as "Create the default HD
> vblock as a copy of the kernel vblock.  For platforms using verified boot, a
> later signing step overwrites this with the vblock signed with the correct key
> for booting from HD."

Thats not how it works though.  At this point the images have already been
signed.  At a later point this is used to overwrite the front of the kernel
partition.

[Randall Spangler, 2010-09-22 18:49:55]

paload -> payload

LGTM after that