Issue 3488002: Volume bubble horizontally centered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3488002: Volume bubble horizontally centered. (Closed)

Created:
10 years, 3 months ago by glotov

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Volume bubble horizontally centered. BUG=chromium-os:5176 TEST=Volume bubble should appear horizontally centered. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60176

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/chromeos/volume_bubble.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

10 years, 3 months ago (2010-09-21 16:36:03 UTC) #2

LGTM.

On Tue, Sep 21, 2010 at 9:30 AM,  <glotov@chromium.org> wrote:
> Reviewers: Daniel Erat,
>
> Description:
> Volume bubble horizontally centered.
> BUG=chromium-os:5176
> TEST=Volume bubble should appear horizontally centered.
>
> Please review this at http://codereview.chromium.org/3488002/show
>
> Affected files:
>  M chrome/browser/chromeos/volume_bubble.cc
>
>
> Index: chrome/browser/chromeos/volume_bubble.cc
> diff --git a/chrome/browser/chromeos/volume_bubble.cc
> b/chrome/browser/chromeos/volume_bubble.cc
> index
>
9b7543a451e86b9b1ccfedc9d5a881b767a1f766..6c71fb345e707e61095f49e7c6bb796cf8e8e949
> 100644
> --- a/chrome/browser/chromeos/volume_bubble.cc
> +++ b/chrome/browser/chromeos/volume_bubble.cc
> @@ -17,7 +17,7 @@ const int kBubbleShowTimeoutSec = 2;
>  const int kAnimationDurationMs = 200;
>
>  // Horizontal relative position: 0 - leftmost, 0.5 - center, 1 - rightmost.
> -const double kVolumeBubbleXRatio = 0.18;
> +const double kVolumeBubbleXRatio = 0.5;
>
>  // Vertical gap from the bottom of the screen in pixels.
>  const int kVolumeBubbleBottomGap = 30;
>
>
>

Expand Messages | Collapse Messages