Issue 348071: First half of http://codereview.chromium.org/274014/show...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348071: First half of http://codereview.chromium.org/274014/show... (Closed)

Created:
11 years, 1 month ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

First half of http://codereview.chromium.org/274014/show This fixes storage events in single process mode, fixes a bug due to the glue/webkitclient_impl not being updated when I introduced quota support, introduces a params struct for storage events, and is general cleanup. Submitting this first since the change to add the url param made things bigger than I liked. TBR=darin TEST=none BUG=25427 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30945

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -90 lines)			Patch
M	chrome/browser/in_process_webkit/browser_webkitclient_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/in_process_webkit/browser_webkitclient_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h	View		4 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc	View		5 chunks	+31 lines, -27 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_uitest.cc	View		3 chunks	+4 lines, -12 lines	0 comments	Download
M	chrome/common/render_messages.h	View		2 chunks	+52 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_thread.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	chrome/renderer/renderer_webkitclient_impl.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/renderer_webkitclient_impl.cc	View		3 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/worker/worker_webkitclient_impl.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/worker/worker_webkitclient_impl.cc	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View		2 chunks	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages