Issue 348069: Restoring r29827....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348069: Restoring r29827.... (Closed)

Created:
11 years, 1 month ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Restoring r29827. The skia file is new to this attempt, and may be what was causing a unit test to crash last time. Refactor security-icon code to a more general form, also more consistent with the Windows implementation, in preparation for implementing page actions. Review URL: http://codereview.chromium.org/264037 BUG=14899, 22922, 12281 TEST=unit tests included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31023

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+320 lines, -132 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field.mm	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_cell.h	View	5 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View	7 chunks	+63 lines, -60 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm	View	6 chunks	+38 lines, -11 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_unittest.mm	View	3 chunks	+19 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.h	View	2 chunks	+76 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.mm	View	4 chunks	+106 lines, -20 lines	0 comments	Download
M	skia/ext/skia_utils_mac.mm	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Pam (message me for reviews)

Avi: Please review the skia file, which is new to this attempt. You're welcome to ...

11 years, 1 month ago (2009-11-04 20:12:00 UTC) #1

LG