Issue 348066: Flip: FlipSessionPool changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348066: Flip: FlipSessionPool changes. (Closed)

Created:
11 years, 1 month ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Flip: FlipSessionPool changes. (1) Move it into the HttpNetworkSession so that HttpNetworkTransaction can access it. This is in anticipation of switching HTTP/HTTPS connections over to FLIP. (2) Add some more functionality to FlipSessionPool, allowing HttpNetworkTransactions to check for the existence of other, reusable FlipSessions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30909

Patch Set 1 #

Patch Set 2 : Windows build fix. #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -91 lines)			Patch
M	net/flip/flip_network_transaction.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	net/flip/flip_network_transaction_unittest.cc	View		3 chunks	+26 lines, -23 lines	0 comments	Download
M	net/flip/flip_session.h	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	net/flip/flip_session.cc	View		3 chunks	+3 lines, -12 lines	0 comments	Download
M	net/flip/flip_session_pool.h	View		1 chunk	+32 lines, -15 lines	0 comments	Download
M	net/flip/flip_session_pool.cc	View	1	3 chunks	+33 lines, -22 lines	0 comments	Download
M	net/http/http_network_layer.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/http/http_network_layer.cc	View		4 chunks	+7 lines, -2 lines	0 comments	Download
M	net/http/http_network_session.h	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	net/http/http_network_session.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View		3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

11 years, 1 month ago (2009-11-04 00:21:54 UTC) #2

lgtm - thanks for all the cleanup!

http://codereview.chromium.org/348066/diff/2001/2002
File net/flip/flip_network_transaction.cc (right):

http://codereview.chromium.org/348066/diff/2001/2002#newcode311
Line 311: flip_ = session_->flip_session_pool()->Get(resolve_info, session_);
Note:  I have another CL with changes in this area, you might get a merge
conflict.

Expand Messages | Collapse Messages