Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 348063: Introduce WebAccessibilityControllerImpl.... (Closed)

Created:
11 years, 1 month ago by dglazkov
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Introduce WebAccessibilityControllerImpl. Removes accessibility-related WebCore dependencies from glue. R=darin TEST=none BUG=24616

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Renamed to webAccessibilityCache. #

Patch Set 4 : More clean up. #

Total comments: 22

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : Licked clean. #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+823 lines, -1660 lines) Patch
M chrome/renderer/render_view.h View 1 2 3 4 3 chunks +3 lines, -2 lines 2 comments Download
M chrome/renderer/render_view.cc View 1 2 3 4 6 chunks +26 lines, -16 lines 0 comments Download
M webkit/api/WebKit.gyp View 3 4 2 chunks +4 lines, -2 lines 0 comments Download
A + webkit/api/public/WebAccessibilityCache.h View 3 4 5 1 chunk +19 lines, -6 lines 2 comments Download
D webkit/api/public/WebAccessibilityController.h View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
MM webkit/api/public/WebAccessibilityObject.h View 2 3 4 5 2 chunks +32 lines, -1 line 2 comments Download
A + webkit/api/src/WebAccessibilityCache.cpp View 3 4 5 1 chunk +45 lines, -45 lines 0 comments Download
A + webkit/api/src/WebAccessibilityCacheImpl.h View 3 4 1 chunk +48 lines, -56 lines 2 comments Download
A + webkit/api/src/WebAccessibilityCacheImpl.cpp View 3 4 1 chunk +95 lines, -240 lines 0 comments Download
D webkit/api/src/WebAccessibilityController.cpp View 3 4 1 chunk +0 lines, -45 lines 0 comments Download
MM webkit/api/src/WebAccessibilityObject.cpp View 2 3 4 5 4 chunks +273 lines, -3 lines 0 comments Download
D webkit/glue/glue_accessibility_object.h View 2 3 4 1 chunk +0 lines, -119 lines 0 comments Download
D webkit/glue/glue_accessibility_object.cc View 2 3 4 1 chunk +0 lines, -482 lines 0 comments Download
M webkit/glue/webaccessibility.h View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
A + webkit/glue/webaccessibility.cc View 1 2 3 4 5 1 chunk +266 lines, -215 lines 0 comments Download
D webkit/glue/webaccessibilitymanager_impl.h View 1 2 3 4 1 chunk +0 lines, -76 lines 0 comments Download
D webkit/glue/webaccessibilitymanager_impl.cc View 1 2 3 4 1 chunk +0 lines, -289 lines 0 comments Download
M webkit/tools/test_shell/accessibility_controller.cc View 4 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/webkit.gyp View 1 2 3 4 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dglazkov
This is nearly complete, but want a sanity check from you. Remaining things: * renaming ...
11 years, 1 month ago (2009-11-04 00:16:04 UTC) #1
darin (slow to review)
This looks really great. http://codereview.chromium.org/348063/diff/2007/2025 File webkit/api/public/WebAccessibilityCache.h (right): http://codereview.chromium.org/348063/diff/2007/2025#newcode50 Line 50: virtual bool initialized() const ...
11 years, 1 month ago (2009-11-04 04:54:14 UTC) #2
dglazkov
http://codereview.chromium.org/348063/diff/2007/2025 File webkit/api/public/WebAccessibilityCache.h (right): http://codereview.chromium.org/348063/diff/2007/2025#newcode50 Line 50: virtual bool initialized() const = 0; On 2009/11/04 ...
11 years, 1 month ago (2009-11-04 17:36:27 UTC) #3
darin (slow to review)
LGTM w/ nits picked: http://codereview.chromium.org/348063/diff/7045/7052 File chrome/renderer/render_view.h (right): http://codereview.chromium.org/348063/diff/7045/7052#newcode51 Line 51: #include "webkit/glue/webaccessibility.h" nit: sort ...
11 years, 1 month ago (2009-11-04 19:17:15 UTC) #4
dglazkov
11 years, 1 month ago (2009-11-04 19:50:05 UTC) #5 
All nitted out. Committing...

http://codereview.chromium.org/348063/diff/7045/7052
File chrome/renderer/render_view.h (right):

http://codereview.chromium.org/348063/diff/7045/7052#newcode51
Line 51: #include "webkit/glue/webaccessibility.h"
On 2009/11/04 19:17:15, darin wrote:
> nit: sort

Done.

http://codereview.chromium.org/348063/diff/7045/7063
File webkit/api/public/WebAccessibilityCache.h (right):

http://codereview.chromium.org/348063/diff/7045/7063#newcode40
Line 40: // FIXME: Should be eliminated to use AXObjectCache instead.
On 2009/11/04 19:17:15, darin wrote:
> nit: this comment should move to WebAccessibilityCacheImpl, right?

Done.

http://codereview.chromium.org/348063/diff/7045/7054
File webkit/api/public/WebAccessibilityObject.h (right):

http://codereview.chromium.org/348063/diff/7045/7054#newcode44
Line 44: struct WebPoint;
On 2009/11/04 19:17:15, darin wrote:
> nit: sort structs after classes.

Done.

http://codereview.chromium.org/348063/diff/7045/7060
File webkit/api/src/WebAccessibilityCacheImpl.h (right):

http://codereview.chromium.org/348063/diff/7045/7060#newcode13
Line 13: class AccessibilityObjectWrapper;
On 2009/11/04 19:17:15, darin wrote:
> nit: no indentation in namespaces now-a-days

Done.

Powered by Google App Engine
This is Rietveld 408576698