Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 348060: Add 'meta charset=UTF-8' to the html of an iframe interstitial to prevent no... (Closed)

Created:
11 years, 1 month ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add 'meta charset=UTF-8' to the html of an iframe interstitial to prevent non-ASCII characters from being garbled. BUG=26030 TEST=1. Launch Chrome with --lang=pt-BR (ja or most languages other than English should work) on Windows or 'LANGUAGE=pt_BR chrome' on Linux. 2. Go to http://www.notalegal.df.gov.br/area=1248.htm and the iframe interstitial doesn't have a garbled character. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30988

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/common/security_filter_peer.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
11 years, 1 month ago (2009-11-03 19:44:41 UTC) #1
jcampan
LGTM
11 years, 1 month ago (2009-11-03 20:22:26 UTC) #2
jungshik at Google
Thank you for lgtm. Can you take another look? I forgot that we now have ...
11 years, 1 month ago (2009-11-03 23:04:45 UTC) #3
jcampan
11 years, 1 month ago (2009-11-03 23:06:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698