Issue 348053: Http cache: Make sure that we handle byte range requests that...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348053: Http cache: Make sure that we handle byte range requests that... (Closed)

Created:
11 years, 1 month ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Http cache: Make sure that we handle byte range requests that end up skipping the cache. BUG=26175 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30877

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	M	net/http/http_cache.cc	View		3 chunks	+8 lines, -3 lines	2 comments	Download
	M	net/http/http_cache_unittest.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

lgtm http://codereview.chromium.org/348053/diff/1/3 File net/http/http_cache.cc (right): http://codereview.chromium.org/348053/diff/1/3#newcode640 Line 640: mode_ = NONE; I expect you need ...

11 years, 1 month ago (2009-11-03 04:51:28 UTC) #2

rvargas (doing something else)

11 years, 1 month ago (2009-11-03 18:28:26 UTC) #3

http://codereview.chromium.org/348053/diff/1/3
File net/http/http_cache.cc (right):

http://codereview.chromium.org/348053/diff/1/3#newcode640
Line 640: mode_ = NONE;
On 2009/11/03 04:51:28, eroman wrote:
> I expect you need to restore headers here too.

This block requires mode_ to be UPDATE so we don't have a byte range request (we
avoid that in SetRequest). I can add a dcheck if you want me to.

Expand Messages | Collapse Messages