[Mac] Do not pump nested tasks in -[NSApp sendEvent:].

chrome/browser/cocoa/tab_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac_util.h"
 #import "chrome/browser/cocoa/tab_controller.h"
 #import "chrome/browser/cocoa/tab_controller_target.h"
 #import "chrome/browser/cocoa/tab_view.h"
 #import "third_party/GTM/AppKit/GTMTheme.h"
 
@@ skipping 29 matching lines @@
                         object:[self view]];
     [defaultCenter addObserver:self
                       selector:@selector(themeChangedNotification:)
                           name:kGTMThemeDidChangeNotification
                         object:nil];
   }
   return self;
 }
 
 - (void)dealloc {
-  // Since the tab can be closed from JavaScript it is possible for
-  // |contextMenu_| to remain visible after the tab has closed, or for
-  // |closeButton_| to be tracking the mouse.  Make sure neither sends
-  // us an action after -dealloc.
-  [closeButton_ setTarget:nil];
-  [contextMenu_ setAutoenablesItems:NO];

[dmac, 2009/11/02 22:29:05]

does it make sense just to call [contextMenu_ cancelTracking] instead of leaving
the menu open?

[Scott Hess - ex-Googler, 2009/11/02 22:35:15]

I had variable success with -cancelTracking.  I was finding cases where it
didn't seem to dismiss the menu.  I do not know why.

-  for (NSMenuItem* item in [contextMenu_ itemArray]) {
-    [item setTarget:nil];
-    [item setEnabled:NO];
-  }
-
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super dealloc];
 }
 
 // The internals of |-setSelected:| but doesn't check if we're already set
 // to |selected|. Pass the selection change to the subviews that need it and
 // mark ourselves as needing a redraw.
 - (void)internalSetSelected:(BOOL)selected {
   selected_ = selected;
   TabView* tabView = static_cast<TabView*>([self view]);
@@ skipping 188 matching lines @@
 // Called by the tabs to determine whether we are in rapid (tab) closure mode.
 - (BOOL)inRapidClosureMode {
   if ([[self target] respondsToSelector:@selector(inRapidClosureMode)]) {
     return [[self target] performSelector:@selector(inRapidClosureMode)] ?
         YES : NO;
   }
   return NO;
 }
 
 @end