Issue 348044: Small fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348044: Small fixes. (Closed)

Created:
11 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Small fixes. Enforce --bot when --url is used. Add a warning when --email is not defined. Set a default --name on rietveld patches. Set return value. TEST=not much BUG=when using --url and not --bot, an exception was thrown

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	trychange.py	View		6 chunks	+22 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 1 month ago (2009-11-03 18:49:00 UTC) #3

http://codereview.chromium.org/348044/diff/1/2
File trychange.py (right):

http://codereview.chromium.org/348044/diff/1/2#newcode576
Line 576: if options.url:
why? It makes total sense to me to specify url byt not bot. Are you sure you are
not working around a bug? GoGetTrySlaves should not fail when url is set but not
bot.

Expand Messages | Collapse Messages