Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: chrome/browser/extensions/extension_devtools_bridge.cc

Issue 348042: Allows extension-devtools api to survive page navigation. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_devtools_bridge.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_devtools_bridge.cc
===================================================================
--- chrome/browser/extensions/extension_devtools_bridge.cc (revision 30714)
+++ chrome/browser/extensions/extension_devtools_bridge.cc (working copy)
@@ -17,7 +17,6 @@
ExtensionDevToolsBridge::ExtensionDevToolsBridge(int tab_id,
Profile* profile)
: tab_id_(tab_id),
- inspected_rvh_(NULL),
profile_(profile),
on_page_event_name_(
ExtensionDevToolsEvents::OnPageEventNameForTab(tab_id)),
@@ -39,10 +38,9 @@
int tab_index;
if (ExtensionTabUtil::GetTabById(tab_id_, profile_, &browser, &tab_strip,
&contents, &tab_index)) {
- inspected_rvh_ = contents->render_view_host();
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
devtools_manager->RegisterDevToolsClientHostFor(
- inspected_rvh_, this);
+ contents->render_view_host(), this);
devtools_manager->ForwardToDevToolsAgent(
this,
DevToolsAgentMsg_SetApuAgentEnabled(true));
@@ -54,11 +52,7 @@
void ExtensionDevToolsBridge::UnregisterAsDevToolsClientHost() {
DCHECK_EQ(MessageLoop::current()->type(), MessageLoop::TYPE_UI);
- if (inspected_rvh_) {
- DevToolsManager::GetInstance()->UnregisterDevToolsClientHostFor(
- inspected_rvh_);
- inspected_rvh_ = NULL;
- }
+ NotifyCloseListener();
}
// If the tab we are looking at is going away then we fire a closing event at
« no previous file with comments | « chrome/browser/extensions/extension_devtools_bridge.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698