Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 348038: Add support for initialization block assignments in the toplevel code... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Add support for initialization block assignments in the toplevel code generator, mimicing the behavior of the optimizing compiler. Initialization blocks can only contain (thus begin and end) with a property assignment in toplevel code. Committed: http://code.google.com/p/v8/source/detail?r=3198

Patch Set 1 #

Patch Set 2 : Add support for initialization block assignments in the toplevel code... #

Patch Set 3 : Add support for initialization block assignments in the toplevel code... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -62 lines) Patch
M src/arm/fast-codegen-arm.cc View 3 chunks +62 lines, -15 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/fast-codegen.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/fast-codegen.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 2 chunks +59 lines, -16 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 2 chunks +58 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 1 month ago (2009-11-02 12:48:38 UTC) #1
William Hesse
11 years, 1 month ago (2009-11-02 13:22:48 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698