Use FilePath in JumpList.

Use FilePath in JumpList.

BUG=24672
TEST=Compiles

Patch by Thiago Farina <thiago.farina@gmail.com>;.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30727

[Evan Martin, 2009-10-31 23:23:08]

Hironori should be the reviewer, I think.  It looks good to me, I just have
minor comments

http://codereview.chromium.org/348035/diff/1/2
File chrome/browser/jumplist.cc (right):

http://codereview.chromium.org/348035/diff/1/2#newcode488
Line 488: FilePath icon_dir_old(icon_dir_.value() + FILE_PATH_LITERAL("Old"));
L"Old" is better than using FILE_PATH_LITERAL because this is Windows-only code

http://codereview.chromium.org/348035/diff/1/2#newcode504
Line 504: (*item)->SetIcon(icon_path.ToWStringHack(), 0, true);
Since this is Windows-only code, you can use icon_path.value() to get a wstring

http://codereview.chromium.org/348035/diff/1/2#newcode519
Line 519: (*item)->SetIcon(icon_path.ToWStringHack(), 0, true);
same here

[tfarina (gmail-do not use), 2009-11-01 00:10:46]

http://codereview.chromium.org/348035/diff/1/2
File chrome/browser/jumplist.cc (right):

http://codereview.chromium.org/348035/diff/1/2#newcode488
Line 488: FilePath icon_dir_old(icon_dir_.value() + FILE_PATH_LITERAL("Old"));
On 2009/10/31 23:23:09, Evan Martin wrote:
> L"Old" is better than using FILE_PATH_LITERAL because this is Windows-only
code 

Removed FILE_PATH_LITERAL.

http://codereview.chromium.org/348035/diff/1/2#newcode504
Line 504: (*item)->SetIcon(icon_path.ToWStringHack(), 0, true);
On 2009/10/31 23:23:09, Evan Martin wrote:
> Since this is Windows-only code, you can use icon_path.value() to get a
wstring

Done.

http://codereview.chromium.org/348035/diff/1/2#newcode519
Line 519: (*item)->SetIcon(icon_path.ToWStringHack(), 0, true);
On 2009/10/31 23:23:09, Evan Martin wrote:
> same here

Done.

[Hironori Bono, 2009-11-02 01:45:20]

LGTM.
Thank you for cleaning up my code. :)

Regards,

Hironori Bono

[Evan Martin, 2009-11-02 18:11:47]

running through trybot now

[Evan Martin, 2009-11-02 19:05:45]

committed, closing

thanks!