Issue 348033: Remove themes/default.dll and merge the resources into chrome.dll.

Issue 348033: Remove themes/default.dll and merge the resources into chrome.dll. (Closed)

Created:
11 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Peter Kasting

CC:
chromium-reviews_googlegroups.com, Glen Murphy, Mark Mentovai

Visibility:
Public.

Description

Remove themes/default.dll and merge the resources into chrome.dll. This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035

Patch Set 1 #

Patch Set 2 : browser #

Total comments: 3

Patch Set 3 : update comments #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -104 lines)			Patch
M	app/resource_bundle.h	View	1 2	4 chunks	+7 lines, -13 lines	0 comments	Download
M	app/resource_bundle.cc	View	1 2	3 chunks	+4 lines, -10 lines	0 comments	Download
M	app/resource_bundle_linux.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	app/resource_bundle_mac.mm	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	app/resource_bundle_win.cc	View		3 chunks	+1 line, -17 lines	0 comments	Download
M	app/test_suite.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/browser_main.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main_mac.mm	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	6 chunks	+8 lines, -38 lines	0 comments	Download
M	chrome/test/unit/chrome_test_suite.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/tools/build/win/FILES	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	views/examples/examples_main.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	views/views.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/348033/diff/1001/2001 File app/resource_bundle.cc (right): http://codereview.chromium.org/348033/diff/1001/2001#newcode112 Line 112: // We loaded successfully. Cache the Skia ...

11 years, 1 month ago (2009-11-02 20:22:01 UTC) #2

cpu_(ooo_6.6-7.5)

11 years, 1 month ago (2009-11-02 20:22:56 UTC) #3

lgtm. Do we need a Mac weenie to look at this?

http://codereview.chromium.org/348033/diff/1001/2002
File app/resource_bundle.h (right):

http://codereview.chromium.org/348033/diff/1001/2002#newcode78
Line 78: // theme data, then in the current module data if applicable.
comment in lines 77 and 78 seems not applicable anymore

http://codereview.chromium.org/348033/diff/1001/2002#newcode126
Line 126: // the theme data, than in the current module data if applicable. 
Returns a
comment seems not applicable anymore

Expand Messages | Collapse Messages