Issue 348030: Webkit roll to 50358.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348030: Webkit roll to 50358. (Closed)

Created:
11 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
dumi, jorlow, Roland Steiner

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Webkit roll to 50358. BUG=none TEST=none TBR=rolandsteiner Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30653

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/storage/open-database-set-empty-version-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/storage/open-database-set-empty-version-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jorlow

You should have added these to the test expectations file rather than adding baselines.

11 years, 1 month ago (2009-10-31 00:53:51 UTC) #1

John Gregg

On 2009/10/31 00:53:51, Jeremy Orlow wrote: > You should have added these to the test ...

11 years, 1 month ago (2009-10-31 00:58:49 UTC) #2

John Gregg

11 years, 1 month ago (2009-10-31 01:00:16 UTC) #3

On 2009/10/31 00:58:49, John Gregg wrote:
> On 2009/10/31 00:53:51, Jeremy Orlow wrote:
> > You should have added these to the test expectations file rather than adding
> > baselines.
> 
> Can you be more specific as to why?  Looking at how the test was failing it
> seems like it was simply a difference in the way error strings are formatted
> between WebKit test and Chrome test environments.

Actually, I can see how I may have judged that too quickly... the outputs are
similar but it does seem like a different category of error.  I can change this.

Expand Messages | Collapse Messages