Issue 348026: Mark the flaky iframe post test as such.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348026: Mark the flaky iframe post test as such. (Closed)

Created:
11 years, 1 month ago by slightlyoff

Modified:
9 years, 7 months ago

Reviewers:
ananta, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Mark the flaky iframe post test as such. R=ananta TEST=none BUG=26372 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30649

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome_frame/test/chrome_frame_unittests.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Drive-by. Please put the bug link when marking the test as flaky.

11 years, 1 month ago (2009-10-30 22:07:34 UTC) #2

Paweł Hajdan Jr.

On 2009/10/30 22:07:34, Paweł Hajdan Jr. wrote: > Drive-by. > > Please put the bug ...

11 years, 1 month ago (2009-10-30 22:07:57 UTC) #3

Paweł Hajdan Jr.

After fixing the nit, LGTM. http://codereview.chromium.org/348026/diff/2002/3001 File chrome_frame/test/chrome_frame_unittests.cc (right): http://codereview.chromium.org/348026/diff/2002/3001#newcode473 Line 473: // flakes out ...

11 years, 1 month ago (2009-10-30 22:20:56 UTC) #5

LGTM

Expand Messages | Collapse Messages

Issue 348026: Mark the flaky iframe post test as such. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages