Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 348024: Disable DownloadTest.PerWindowShelf because of flakiness.... (Closed)

Created:
11 years, 1 month ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paul Godavari, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable DownloadTest.PerWindowShelf because of flakiness. BUG= http://crbug.com/26325 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30590

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/download/download_uitest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Miranda Callahan
11 years, 1 month ago (2009-10-30 17:03:11 UTC) #1
stuartmorgan
http://codereview.chromium.org/348024/diff/1/2 File chrome/browser/download/download_uitest.cc (right): http://codereview.chromium.org/348024/diff/1/2#newcode252 Line 252: TEST_F(DownloadTest, DISABLED_PerWindowShelf) { Should we used FLAKY_ instead?
11 years, 1 month ago (2009-10-30 17:10:01 UTC) #2
Miranda Callahan
http://codereview.chromium.org/348024/diff/1/2 File chrome/browser/download/download_uitest.cc (right): http://codereview.chromium.org/348024/diff/1/2#newcode252 Line 252: TEST_F(DownloadTest, DISABLED_PerWindowShelf) { On 2009/10/30 17:10:01, stuartmorgan wrote: ...
11 years, 1 month ago (2009-10-30 17:14:09 UTC) #3
stuartmorgan
11 years, 1 month ago (2009-10-30 17:16:36 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698