Add the "Other bookmarks" button on the right of the bookmark bar....

chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/basictypes.h"
 #include "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/cocoa/bookmark_bar_constants.h"
@@ skipping 200 matching lines @@
   EXPECT_EQ(0, [[bar_ view] frame].size.height);
 }
 
 TEST_F(BookmarkBarControllerTest, ShowOnNewTabPage) {
   helper_.profile()->GetPrefs()->SetBoolean(prefs::kShowBookmarkBar, false);
 
   scoped_nsobject<BookmarkBarControllerTogglePong> bar;
   bar.reset(
       [[AlwaysNewTabPageBookmarkBarController alloc]
           initWithBrowser:helper_.browser()
-             initialWidth:100  // arbitrary
+             initialWidth:800  // arbitrary
          compressDelegate:compressDelegate_.get()
            resizeDelegate:resizeDelegate_.get()
               urlDelegate:nil]);
   InstallAndToggleBar(bar.get());
 
   [bar setBookmarkBarEnabled:NO];
   [bar updateVisibility];
 
   EXPECT_TRUE([bar isVisible]);
   EXPECT_FALSE([[bar view] isHidden]);
   EXPECT_GT([resizeDelegate_ height], 0);
   EXPECT_GT([[bar view] frame].size.height, 0);
+
+  // Make sure no buttons fall off the bar, either now or when resized
+  // bigger or smaller.
+  CGFloat sizes[] = { 300.0, -100.0, 200.0, -420.0 };
+  CGFloat previousX = 0.0;
+  for (unsigned x = 0; x < arraysize(sizes); x++) {
+    // Confirm the buttons moved from the last check (which may be
+    // init but that's fine).
+    CGFloat newX = [[bar offTheSideButton] frame].origin.x;
+    EXPECT_NE(previousX, newX);
+    previousX = newX;
+
+    // Confirm the buttons have a reasonable bounds.
+    EXPECT_TRUE(NSContainsRect([[bar buttonView] frame],
+                               [[bar offTheSideButton] frame]));
+    EXPECT_TRUE(NSContainsRect([[bar buttonView] frame],
+                               [[bar otherBookmarksButton] frame]));
+
+    // Now move them implicitly.
+    // We confirm FrameChangeNotification works in the next unit test;
+    // we simply assume it works here to resize or reposition the
+    // buttons above.
+    NSRect frame = [[bar view] frame];
+    frame.size.width += sizes[x];
+    [[bar view] setFrame:frame];
+  }
 }
 
 // Make sure we're watching for frame change notifications.
 TEST_F(BookmarkBarControllerTest, FrameChangeNotification) {
   scoped_nsobject<BookmarkBarControllerTogglePong> bar;
   bar.reset(
     [[BookmarkBarControllerTogglePong alloc]
           initWithBrowser:helper_.browser()
              initialWidth:100  // arbitrary
          compressDelegate:compressDelegate_.get()
@@ skipping 301 matching lines @@
   EXPECT_TRUE(i == end);
 
   EXPECT_EQ(pong.get()->dispositions_[3], NEW_BACKGROUND_TAB);
 
   [bar_ setUrlDelegate:nil];
 }
 
 // TODO(jrg): write a test to confirm that nodeFavIconLoaded calls
 // checkForBookmarkButtonGrowth:.
 
-// TODO(jrg): Make sure showing the bookmark bar calls loaded: (to
-// process bookmarks)
-TEST_F(BookmarkBarControllerTest, ShowAndLoad) {
-}
+TEST_F(BookmarkBarControllerTest, Cell) {
+  BookmarkModel* model = helper_.profile()->GetBookmarkModel();
+  [bar_ loaded:model];
 
-// TODO(jrg): Test cellForBookmarkNode:
-TEST_F(BookmarkBarControllerTest, Cell) {
-}
+  const BookmarkNode* parent = model->GetBookmarkBarNode();
+  model->AddURL(parent, parent->GetChildCount(),
+                L"supertitle",
+                GURL("http://superfriends.hall-of-justice.edu"));
+  const BookmarkNode* node = parent->GetChild(0);
 
-TEST_F(BookmarkBarControllerTest, Contents) {
-  // TODO(jrg): addNodesToBar has a LOT of TODOs; when flushed out, write
-  // appropriate tests.
+  NSCell* cell = [bar_ cellForBookmarkNode:node];
+  EXPECT_TRUE(cell);
+  EXPECT_TRUE([[cell title] isEqual:@"supertitle"]);
+  EXPECT_EQ(node, [[cell representedObject] pointerValue]);
+
+  // cell is autoreleased; no need to release here
 }
 
 // Test drawing, mostly to ensure nothing leaks or crashes.
 TEST_F(BookmarkBarControllerTest, Display) {
   [[bar_ view] display];
 }
 
 // Test that middle clicking on a bookmark button results in an open action.
 TEST_F(BookmarkBarControllerTest, MiddleClick) {
   BookmarkModel* model = helper_.profile()->GetBookmarkModel();
@@ skipping 116 matching lines @@
   BookmarkModel* model = helper_.profile()->GetBookmarkModel();
   const BookmarkNode* parent = model->GetBookmarkBarNode();
   [bar_ addURLs:nsurls withTitles:nstitles at:NSZeroPoint];
   EXPECT_EQ(3, parent->GetChildCount());
   for (int i = 0; i < parent->GetChildCount(); ++i) {
     EXPECT_EQ(parent->GetChild(i)->GetURL(), GURL(urls[i]));
     EXPECT_EQ(parent->GetChild(i)->GetTitle(), titles[i]);
   }
 }
 
-
-// Cannot test these methods since they simply call a single static
-// method, BookmarkEditor::Show(), which is impossible to mock.
-// editBookmark:, addPage:
-
-
 }  // namespace