Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3965)

Unified Diff: chrome/browser/browser.cc

Issue 348015: Fix and re-enable a test I broke with the find bar changes I made last night.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 30478)
+++ chrome/browser/browser.cc (working copy)
@@ -271,6 +271,10 @@
return find_bar_controller_.get();
}
+bool Browser::HasFindBarController() const {
+ return find_bar_controller_.get() != NULL;
+}
+
///////////////////////////////////////////////////////////////////////////////
// Browser, Creation Helpers:
@@ -1777,7 +1781,7 @@
status_bubble->SetStatus(GetSelectedTabContents()->GetStatusText());
}
- if (find_bar_controller_.get()) {
+ if (HasFindBarController()) {
find_bar_controller_->ChangeTabContents(new_contents);
find_bar_controller_->find_bar()->MoveWindowIfNecessary(gfx::Rect(), true);
}

Powered by Google App Engine
This is Rietveld 408576698