Issue 3479002: Default IDR_MENU_DROPARROW is unsuitable for us because it is too opaque....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3479002: Default IDR_MENU_DROPARROW is unsuitable for us because it is too opaque.... (Closed)

Created:
10 years, 3 months ago by Denis Lagno

Modified:
9 years, 6 months ago

Reviewers:
whywhat

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Default IDR_MENU_DROPARROW is unsuitable for us because it is too opaque. Added IDR_MENU_DROPARROW_SHARP with more transparent background. BUG=http://crosbug.com/6568 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60162

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, --1 lines)			Patch
M	app/resources/app_resources.grd	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A +	app/resources/menu_droparrow_sharp.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/3479002/diff/1/4 File chrome/browser/chromeos/login/new_user_view.cc (right): http://codereview.chromium.org/3479002/diff/1/4#newcode7 chrome/browser/chromeos/login/new_user_view.cc:7: #include <stdio.h> Could we include <cstdio> and <cstdlib>?

10 years, 3 months ago (2010-09-21 18:16:20 UTC) #2

Denis Lagno

10 years, 3 months ago (2010-09-21 20:17:44 UTC) #3

> http://codereview.chromium.org/3479002/diff/1/4#newcode7
> chrome/browser/chromeos/login/new_user_view.cc:7: #include <stdio.h>
> Could we include <cstdio> and <cstdlib>?

Oh, thanks for noticing.  Those includes were left after debugging.  They are
not needed, will remove it before commit.

Expand Messages | Collapse Messages